Add installation script to facillitate installation#7
Add installation script to facillitate installation#7sampoz wants to merge 10 commits intoofosos:masterfrom
Conversation
|
Hey @sampoz ! That looks good. |
|
So, will you merge the script? That would be kind. |
* Assume user has setup rmapi to her path
|
Managed to find a bit of time and serenity to improve this. |
|
@ofosos This is (hopefully) getting closer to merging, if you happen to have some spare time, could you check this out and maybe test it with your setup? I have tested this only with my setup. Anyways, thanks for the original work, printing straight to RM is pretty cool 🎉 |
* Did not have time to debug, sorry!
|
I can report that the install script worked on my machine as well, running an Arch Linux installation. |
|
As I do not want to start a fork of a fork to create a patch of a patch I thought we can discuss this here: I propose that the installation script This should make the installation script more fail-safe. Furthermore, I would consider taking into account that rmapi has an issue about installing in the config into the standard XDG_CONFIG folder (e.g. ~/.config/rmapi). click here If this is going to happen, the installation script will fail. Maybe one can leave a note for the future self in the script pointing to the issue and the possible solution, thus it is quickly fixed. |
|
First of all, thanks for feedback!
Excellent plan and a good catch on the "use before create" on the folder. I thought about this on the first pass, but forgot it when hammering down the current version 😅 I don't know when I will have time to implement this, but if it takes long, this PR should be merged
Okay, good detective work! I'll add this to the todo. New todo:
|
Hi!
Thanks for awesome tool for printing straight to reMarkable. I has benefited my workflow significantly!
Here is a small improvement that might help others to install this fine piece of software :>
Features still needed:
[✓] Basic installation script
[✓] Finding rmapi-bin -folder for user in order to template
rmapi-variable forremarkable.sh-scriptPossible additional features:
[✓] Prompt user for test-printing (test installation success + demo's the software)
[ ] Remove need for root user, or at least move the binary to root's home
Cheers!