Conversation
|
The README describes setting up a LaML Application with a Request URL, but the code uses SignalWire's Realtime API instead. The Realtime API typically requires configuring the phone number to use the Relay context with your project credentials, not a LaML app. Please update the README to correct the setup instructions for Realtime API. |
|
In |
|
The current implementation prompts users to enter a PIN, echoes it back, and hangs up without any conference logic. For a "basic connection" system, you might want to add initial steps like checking if the PIN is correct and proceeding to join or start a conference (using SignalWire's conference methods). |
|
Echoing the PIN back to the caller is not secure and could lead to unintended disclosure. Consider removing the |
|
There's a TODO in the code for adding error handling. Ensure to handle cases where the PIN prompt fails or the call encounters errors to make the system robust. |
Changes RequestedSummary of Changes
Overall FeedbackStrong start on the project foundations and build setup. However, the core conference functionality still needs to be added to make this a "basic connection" system—calls hang up after PIN entry without joining. Let's fix the PIN echo security issue, align digit counts, update the README for Realtime API, and implement the conference join logic as suggested in earlier comments. Keep up the good work! 🚀 |
|
In
|
Basic system for answering a call.
For now, we just test basic TTS and prompting. Conference call logic will be later.