Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new project that enables simultaneous audio output on multiple devices along with dedicated controls for oscillator settings and device management. Key changes include the implementation of React components for device selection and oscillator control, updates to state management using Jotai, and accompanying configuration and documentation enhancements.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/audio-multi-output/features/OutputController/DevicePanel.tsx | Added UI panel for controlling device-specific oscillator settings. |
| src/audio-multi-output/features/OscillatorControl/* | Implemented oscillator control components, including waveform selection, frequency slider, and phase inversion switch. |
| src/audio-multi-output/features/DeviceManager/* | Built components and logic for managing and selecting audio output devices. |
| src/audio-multi-output/consts/audioConsts.ts | Defined constants for device labels, sample rate, buffer size, and error messages. |
| src/audio-multi-output/App.tsx | Integrated all modules within the main application and added browser support checks. |
| Additional files (atom.ts, index.ts, README.md, Scratchpad.md, eslint.config.js) | Updated configuration, state management, documentation, and linting settings for project consistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
複数の音声出力デバイス、例えばヘッドホンとモニターなどから、同時に音を鳴らすウェブアプリ。
左のディスプレイから正弦波、右のディスプレイからその逆位相を流してみたが、そのままだとタイミングがズレてしまう。
これのタイミングをあわせる方法、もしくは位相をリアルタイムで調整する方法を探りたい。
最終的には、簡易的なノイズキャンセリング体験ができると良い。