Open
Conversation
|
Thoughts on reusing |
|
The logic in your listener for setting the Destination is a copy paste of what's in the command, they should be refactored out into a common function |
Contributor
Author
Yeah, true. Added in 954e4c8. |
okx-code
requested changes
Aug 7, 2019
Owner
okx-code
left a comment
okx-code
left a comment
There was a problem hiding this comment.
This should support all aliases of the /dest command (/dest, /destination, /setdest, pulled from plugin.getDescription())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion: allow players to set their destination be right clicking on signs which specify the destination. Sign can be formatted by starting a line with "/dest " followed by the destination or by ending a line with "/dest" then putting the destination string on the next line. It also might be nice if we added this feature to books, an interactive travel guide sounds like a novel and practical idea.