Open
Conversation
bylingo
force-pushed
the
bylingo/2010-rocksdb-parameter-misspelling-info
branch
from
d80fe45 to
4c4c005
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #3045 +/- ##
==========================================
- Coverage 36.24% 36.08% -0.17%
==========================================
Files 428 434 +6
Lines 44860 45124 +264
==========================================
+ Hits 16261 16281 +20
- Misses 27425 27668 +243
- Partials 1174 1175 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
giskook
reviewed
Mar 25, 2023
| } | ||
| } | ||
|
|
||
| rocksDBMisspelling(ctx) |
Contributor
There was a problem hiding this comment.
Maybe we can find a more common way to do the check, just like sanity check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdReviewed
Files changedin the github PR explorerFor Admin Use: