Open
Conversation
…optimize # Conflicts: # cmd/hack/hack.go
dloghin
reviewed
Sep 4, 2025
|
|
||
| func processScalableAddressStorageConcurrently(db kv.RwDB, prefix []byte, acct *AccInfo) (uint64, error) { | ||
|
|
||
| numWorkers := 32 |
There was a problem hiding this comment.
should we use "numWorkers := runtime.NumCPU()"?
Vui-Chee
reviewed
Sep 5, 2025
|
|
||
| for i := 0; i < numChunks; i++ { | ||
| startKey := make([]byte, 32) | ||
| startKey[0] = byte(i * (256 / numChunks)) |
Collaborator
There was a problem hiding this comment.
You initialize startKey with 32 bytes, but the the following assignment only assigns the first byte in the array. Is it because workerTx.Range(kv.PlainState, startKey, endKey) requires each key to be 60 bytes long?
Vui-Chee
reviewed
Sep 5, 2025
Comment on lines
+734
to
+735
| scalableStorageCount, err := processScalableAddressStorageConcurrently(db, k[:28], acc) | ||
| acctStorageCount = scalableStorageCount |
Collaborator
There was a problem hiding this comment.
Can we omit scalableStorageCount? And just assign acctStorageCount directly?
Vui-Chee
reviewed
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use multiple threads to scan scalable contracts, reduce scanning time from 46s to 29.6s