Conversation
added attribute for pin updated sample application
krazykira
left a comment
There was a problem hiding this comment.
Thanks for the contribution but i think the solution is not scalable in this way rather i would suggest you update the mrb_temporaryPins attribute from boolean to enum
The following things you would need to add.
- Define an enum
PinDisplayPropertieshaving the valuesALWAYS,NEVER,ONLY_ON_TOUCH - Add way to change
mrb_temporaryPinsfrom xml. - Add way to change
mrb_temporaryPinsfrom code. - Update the sample app accordingly so that we have the ability to see the different properties of
mrb_temporaryPins
| <attr name="mrb_pinRadius" format="dimension"/> | ||
| <attr name="mrb_connectingLineColors" format="reference"/> | ||
| <attr name="mrb_onlyOnDrag" format="boolean"/> | ||
| <attr name="mrb_pinsEnabled" format="boolean"/> |
There was a problem hiding this comment.
we already have a property mrb_temporaryPins and i think this one should be changed so it should have the following three values
- ALWAYS (This displays them all the time)
- NEVER (This hides them all the time)
- ON_TOUCH_ONLY (This displays them when we are modifying the value and then hides them )
1 & 3 can be achieved right now by changing value for mrb_temporaryPins to true and false but the 2nd one is what you have to implement and at the same time you need to change the mrb_temporaryPins
So at the end the mrb_temporaryPins would be changed to something like this
<attr name="mrb_temporaryPins" format="enum">
<enum name="ALWAYS" value="0" />
<enum name="NEVER" value="1" />
<enum name="ON_TOUCH_ONLY" value="2" />
</attr>
|
@svkaka can we have an ETA on the changes. I would like to release a new version in May and this could be added if the changes are done in time |
|
@svkaka Please resolve conflicts as well |
added attribute for the pin
updated sample application