Merged
Conversation
🦋 Changeset detectedLatest commit: 27e225e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
added 5 commits
February 11, 2026 17:33
Add the ability to hide elements by domain. Hidden elements are stored in heroshot.config.json under `hiddenElements` (hostname → CSS selectors) and applied during both interactive editing and CLI sync capture. Editor UI: hide mode button (eye-slash), red hover highlight, collapsible "Hidden" list in sidebar with per-selector unhide buttons. Also fixes a bug where Toolbar used document.querySelectorAll for Playwright-style selectors (text=, role=) — now uses queryElements from selectorGenerator. Includes 9 Playwright e2e tests covering hide/unhide flow, events, pre-loaded elements, and mode toggling.
- EditorBar: hide mode button + hidden elements list with unhide - ElementPicker: red highlight in hide mode, auto-deactivate after hide - Toolbar: state management, DOM application via queryElements() - SelectorGenerator: public query() method for non-CSS selectors - CLI: schema, types, injection, config persistence, capture integration - E2e tests: 9 tests covering hide/unhide/persistence/mode toggling - Updated visual regression snapshots for new hide button
- Extract handleEvent into separate handleEvent.ts to stay under max-lines - Add changeset for minor version bump
omachala
force-pushed
the
feat/per-domain-element-hiding
branch
from
fb32811 to
5c45331
Compare
added 8 commits
February 12, 2026 20:40
Add outputDirectory, outputFormat, jpegQuality, and workers fields to the Settings modal alongside existing browser settings. Values are read from config on open and saved back on close.
Remove ignoreSnapshots flag so e2e snapshots are compared on every CI run. Add manual workflow to update editor snapshots on any branch. Update 3 stale settings snapshots.
CI runs in Docker container with different font rendering than host, causing 11% pixel diff on visual snapshots. Re-enable ignoreSnapshots for CI environment. Pin GitHub Actions to full commit SHAs to resolve SonarCloud security hotspot.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiddenElementsconfig field inheroshot.config.jsonmaps hostname → CSS selectorsexecuteHide)$effectuseddocument.querySelectorAll()which can't handle Playwright-style selectors — addedqueryElements()viaSelectorGenerator.query()