Merged
Conversation
…and accessibility - Extract 4 modules from ElementPicker (1354→~870 lines): textEditing, paddingResize, backgroundFill, overlayGeometry - Add 78 annotation unit tests for arrow, rect, ellipse types - Add 10 annotation E2E tests covering draw, move, delete, and selection lifecycle - Create shared constants.ts replacing magic numbers across 5 files - Add ARIA labels and keyboard resize support for padding handles - RAF-throttle scroll handler for performance - Add console warnings for silent failures (highlightElement retries, text override misses) - Delete unused StyleEditor.svelte (132 lines)
🦋 Changeset detectedLatest commit: 572519f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Fix Object possibly undefined errors in annotation E2E tests - Exclude extracted browser-only modules from unit test coverage - Add empty changeset for internal refactoring
omachala
force-pushed
the
editor-quality-improvements
branch
from
d0d7c89 to
572519f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
textEditing.ts,paddingResize.ts,backgroundFill.ts,overlayGeometry.tsconstants.tsreplacing magic z-indices, timeouts, and colors across 5 filesaria-pressed/aria-expandedstates, keyboard resize on padding handles (arrow keys)highlightElementretry exhaustion and text override selector missesStyleEditor.svelte(132 lines)Test plan
pnpm test:editor— 337 unit tests passpnpm test:editor:e2e— 51 E2E tests pass (6 pre-existing snapshot failures from Chrome version diff)pnpm lint:editor— cleanpnpm typecheck:editor— cleanpnpm build:editor— builds successfully