Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded support for Claude Opus 4-6 and GLM-5 across provider defaults and mappings; updated provider default model slices and an Azure test; adjusted example model mappings and routing identifiers. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2cd3029 to
de80751
Compare
There was a problem hiding this comment.
Pull request overview
Updates default model inventories and example configuration to reflect newer Claude/Z.AI model identifiers across providers.
Changes:
- Add
claude-opus-4-6to default model lists for Anthropic, Azure, Bedrock, and Vertex; addGLM-5to Z.AI defaults and removeGLM-4-Plus. - Update
example.yamlto include the new models and refresh model/provider mapping examples. - Adjust
go.sumentries consistent with dependency tidying.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/providers/zai.go | Updates default Z.AI model list (adds GLM-5, removes GLM-4-Plus). |
| internal/providers/vertex.go | Adds a new default Vertex model entry. |
| internal/providers/bedrock.go | Adds a new default Bedrock model entry. |
| internal/providers/azure.go | Adds a new default Azure model entry. |
| internal/providers/anthropic.go | Adds a new default Anthropic model entry. |
| internal/providers/azure_test.go | Extends assertions to cover the newly added Azure default model. |
| example.yaml | Updates example routing/provider model lists and model mappings to include new models. |
| go.sum | Removes unused/older checksum entries (likely go mod tidy). |
Comments suppressed due to low confidence (1)
internal/providers/vertex.go:36
- DefaultVertexModels is documented as using the Vertex format
model-name@version, but the newly added entryclaude-opus-4-6has no@...version. If Vertex requires a versioned model ID in the URL path, this will cause requests to fail; otherwise the comment is now inaccurate. Please either update the model ID to the correct@versionform or adjust the comment (and any related config examples) to reflect that unversioned IDs are valid here.
// DefaultVertexModels are the default models available from Vertex AI.
// Model IDs use Vertex format: model-name@version.
var DefaultVertexModels = []string{
"claude-opus-4-6",
"claude-sonnet-4-5@20250514",
"claude-opus-4-5@20250514",
"claude-haiku-3-5@20241022",
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # claude-sonnet: anthropic # claude-sonnet-* → anthropic | ||
| # glm-4: zai # glm-4* → zai | ||
| # glm: zai # glm* → zai | ||
| # qwen: ollama # qwen* → ollama |
There was a problem hiding this comment.
The routing.model_mapping example uses a lowercase glm prefix, but model-based routing is case-sensitive (uses strings.HasPrefix) and the Z.AI models shown later in this file are GLM-... uppercase. As written, routing won't match requests for GLM-5/GLM-4.7. Update the example prefix to match the actual model IDs (or document that model matching is case-sensitive).
| model_mapping: | ||
| "claude-sonnet-4-5-20250929": "claude-sonnet-4-5@20250929" | ||
| "claude-sonnet-4-5": "claude-sonnet-4-5@20250929" | ||
| "claude-opus-4-6": "claude-opus-4-6" |
There was a problem hiding this comment.
The Vertex provider is documented as requiring model-name@version IDs, but the example Vertex model_mapping maps claude-opus-4-6 to an unversioned claude-opus-4-6. If Vertex expects a version suffix, this example will produce invalid request URLs. Please update the mapping to the correct Vertex model ID format (or update the surrounding documentation if unversioned IDs are intended/supported).
| "claude-opus-4-6": "claude-opus-4-6" | |
| "claude-opus-4-6": "claude-opus-4-6@20250219" |
example.yaml
Outdated
| "claude-opus-4-6": "anthropic.claude-opus-4-6-v1:0" | ||
| "claude-sonnet-4-5-20250929": "anthropic.claude-sonnet-4-5-20250929-v1:0" | ||
| "claude-sonnet-4-5": "anthropic.claude-sonnet-4-5-20250929-v1:0" | ||
| "claude-haiku-4-5-20251001": "anthropic.claude-haiku-4-5-20251001-v1:0" |
There was a problem hiding this comment.
This Bedrock model_mapping section still references the claude-sonnet-4-5-20250929 / ...-20250929-v1:0 IDs, but the code defaults in this PR were updated to ...-20250514.... Keeping a future-dated mapping here is inconsistent with the updated defaults and likely to confuse users copying the example. Consider updating these mappings (or adding additional entries) to align with the 20250514 model IDs used elsewhere in the repo.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 78.15% 78.18% +0.03%
==========================================
Files 94 94
Lines 5800 5800
==========================================
+ Hits 4533 4535 +2
+ Misses 980 979 -1
+ Partials 287 286 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



No description provided.