Update strict_well.schema #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated Review URLs |
This reverts commit 272445b.
Contributor
Author
|
Update: Deleting the schema leads to failing tests, which may happen elsewhere, too, if schema checkers depend on the existence of the strict schema. Kept it around, but removed the |
jo-mueller
changed the title
jo-mueller
changed the title
clbarnes
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ome/ngff#312
After #84 is merged, there is no need for the
strict_wellschema anymore. The onlySHOULDstatement in for thewellspec was the version key, which already had been removed from the schema in a previous version. This makes thestrict_wellschema functionally equivalent to thewellschema so I figured one may as well be removed?Alternatively, the
allOfcould be removed, too.