omero fields optional #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ported from ome/ngff#297
Automated Review URLs |
jo-mueller
reviewed
Feb 5, 2026
jo-mueller
reviewed
Feb 5, 2026
Comment on lines
+1536
to
+1537
| - `min` (float) Should correspond to the minimum pixel intensity for that channel. | ||
| - `max` (float) Should correspond to the maximum pixel intensity for that channel. |
Contributor
There was a problem hiding this comment.
Suggested change
| - `min` (float) Should correspond to the minimum pixel intensity for that channel. | |
| - `max` (float) Should correspond to the maximum pixel intensity for that channel. | |
| - `min` (float) Default setting for lower bound for values of `start` field. | |
| - `max` (float) Default setting for upper bound for values of `end` field. |
Member
Author
There was a problem hiding this comment.
I used "should" here because I want it to be clear that this is not enforced: The file isn't invalid if you don't quite get this correct. E.g. if you use a down-sampled resolution, or just the middle Z-section to calculate the min/max then it may not actually be the "Maximum pixel intensity for that channel"
jo-mueller
reviewed
Feb 5, 2026
Co-authored-by: Johannes Soltwedel <38459088+jo-mueller@users.noreply.github.com>
Co-authored-by: Johannes Soltwedel <38459088+jo-mueller@users.noreply.github.com>
lubianat
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ome/ngff#192
ported from ome/ngff#297