Conversation
…directory-search - contacts update: fetch existing contact first to include source metadata required by the People API, fixing potential 400 failedPrecondition errors. Also use cmd.Flags().Changed() to detect intent, allowing empty-string updates. - batch-create/batch-update: surface per-item failures instead of silently dropping entries where Person is nil. Output now includes failed/failed_count. - directory-search: add pagination loop so --max values above 500 are honored. - resolve: distinguish NOT_FOUND (code 5) from other API errors instead of misclassifying all non-person responses as not_found. - docs: remove phantom --query flag from directory command documentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The People API requires person.metadata.sources for UpdateContact. Without fetching metadata, the prefetch-and-merge approach would still fail with 400 failedPrecondition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…fields - Rename `errors` to `apiErrors` in resolve to avoid shadowing the built-in errors package identifier. - Document optional `failed`/`failed_count` output fields for batch-create and batch-update in commands.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge review fixes for PR #125 (contacts parity). Addresses issues found by both PR-reviewer and Codex:
400 failedPreconditionerrors. Now usescmd.Flags().Changed()to detect flag intent, allowing empty-string updates to clear fields.Personis nil. Output now includesfailedandfailed_countfields.--maxvalues above 500 (the API page limit) are properly honored.NOT_FOUND(gRPC code 5) from other API errors instead of misclassifying all non-person responses asnot_found.--queryflag fromdirectorycommand documentation in both SKILL.md and commands.md.Test plan
go vet ./...cleango test ./...all passgws contacts updatewith real contactgws contacts directory-search --max 600with Workspace account🤖 Generated with Claude Code