test: add command-level validation tests, move validation before client creation#132
Merged
test: add command-level validation tests, move validation before client creation#132
Conversation
…nt creation Add validation_test.go with tests that exercise run* functions through Cobra commands, catching validation errors before any API call: - Forms: --file + --title conflict, no-flags error - Sheets: --value required for conditional format rules, negative --index - Slides: invalid --size rejection - Contacts: update with no field flags Move flag validation before client.NewFactory() in all affected commands so validation errors fire before OAuth credential checks. This improves UX (faster, clearer errors) and makes the validations testable without a mock server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the systemic test gap identified across all 7 post-merge reviews:
_MockServertests don't exerciserun*functions.New validation tests (
cmd/validation_test.go):--file+--titleconflict guard, no-flags error--valuerequired for 7 conditional format rule types, negative--indexrejection--sizerejectionProduction code improvement — moved flag validation before
client.NewFactory()in:runFormsUpdaterunSheetsAddConditionalFormatrunSheetsDeleteConditionalFormatrunSlidesThumbnailrunContactsUpdateThis makes validation errors fire before OAuth credential checks, improving UX (faster, clearer errors) and making the code testable without mock servers.
Test plan
go vet ./...cleango test ./...all pass (12 new test cases)🤖 Generated with Claude Code