Wip df #47
Open
Wip df #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new python-ceph-cfg function osd_df to report disk usage. Signed-off-by: Owen Synge <osynge@suse.com>
Use new python-ceph-cfg function cluster_df to report disk usage. Signed-off-by: Owen Synge <osynge@suse.com>
| def osd_df(**kwargs): | ||
| """ | ||
| OSD disk space report | ||
|
|
Contributor
There was a problem hiding this comment.
Do osd_df and cluster_df differ in what they report? Other then one OSD vs. all OSDs? If not, why not make the docs consistent? Maybe 'Get an OSDs free space'
Or does osd_df report other things too? Then a different name might be appropriate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the OSD and cluster disk space.
Note this PR depends upon this PR oms4suse/python-ceph-cfg#32