Skip to content

fix: ensure extracted directories stay writable #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qkaiser merged 1 commit into from
Dec 11, 2025
Merged

fix: ensure extracted directories stay writable #1321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/unblob/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,10 @@ def mkdir(self, path: Path, *, mode=0o777, parents=False, exist_ok=False):
logger.debug("creating directory", dir_path=path, _verbosity=3)
safe_path = self._get_extraction_path(path, "mkdir")

safe_path.mkdir(mode=mode, parents=parents, exist_ok=exist_ok)
# Directories with restrictive permission bits (e.g. 0o000) immediately
# block creation of nested entries, so force owner rwx during extraction.
safe_mode = mode | 0o700
safe_path.mkdir(mode=safe_mode, parents=parents, exist_ok=exist_ok)

def mkfifo(self, path: Path, mode=0o666):
logger.debug("creating fifo", path=path, _verbosity=3)
Expand Down
Loading