Skip to content

Comments

Add support for thecodingmachine safe 3 0#10

Open
turingal wants to merge 4 commits intoonmoon:masterfrom
turingal:add-support-for-thecodingmachine-safe-3-0
Open

Add support for thecodingmachine safe 3 0#10
turingal wants to merge 4 commits intoonmoon:masterfrom
turingal:add-support-for-thecodingmachine-safe-3-0

Conversation

@turingal
Copy link

@turingal turingal commented Feb 4, 2026

No description provided.

@sspat
Copy link
Collaborator

sspat commented Feb 10, 2026

@turingal I ran the CI jobs, please see the highlighted issues:

https://github.com/onmoon/money/pull/10/checks

Most of the jobs were cancelled because the first one failed:
https://github.com/onmoon/money/actions/runs/21685415324/job/63106900099?pr=10

It tries to install the minimum allowed versions of packages with
composer update --prefer-lowest --no-interaction --no-progress --no-suggest.
This is required because libraries don’t commit their package lock files to version control, allowing the user of the package to install from a broad range of versions depending on their project’s requirements. We must test that the package is installable and works under this broad range of dependency versions.

Also note that by limiting version constraints to only the latest versions, we restrict the end user of the package. Therefore, the broad version range should preferably be kept if possible (e.g., we add support for thecodingmachine/safe 3.0 on top of 1.3 and 2, not replace support for 1.3 and 2 with only supporting 3.0). The same applies to other version constraints you changed in the pull request.

You can inspect the configuration of the various CI jobs in the repository and reproduce them locally with the corresponding PHP versions and composer install arguments to ensure the CI jobs will install and pass when committed to the repository.

@sspat
Copy link
Collaborator

sspat commented Feb 10, 2026

Here is an example in our other package that supports the whole range of thecodingmachine/safe versions:
https://github.com/onmoon/openapi-server-bundle/blob/055e85d669d9fe5e2fc04f6c1939bb55ba78d616/composer.json#L44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants