Skip to content

feat(webconnectivitylte): introduce "tls" blocking state #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bassosimone wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(webconnectivitylte): introduce "tls" blocking state #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/experiment/webconnectivitylte/analysisclassic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func analysisClassicComputeBlockingAccessible(woa *minipipeline.WebAnalysis, tk
}

// 3.1.2. Otherwise, if the control worked, that's blocking.
tk.setBlockingString("http-failure")
tk.setBlockingString("tls")
tk.setHTTPExperimentFailure(entry.Failure)
return
}
Expand All @@ -306,7 +306,7 @@ func analysisClassicComputeBlockingAccessible(woa *minipipeline.WebAnalysis, tk
}

// 3.3. Handle the case where just the probe failed.
tk.setBlockingString("http-failure")
tk.setBlockingString("tls")
tk.setHTTPExperimentFailure(entry.Failure)
return
}
Expand All @@ -327,7 +327,7 @@ func analysisClassicComputeBlockingAccessible(woa *minipipeline.WebAnalysis, tk
}

// 4.1.2. Otherwise, if the control worked, that's blocking.
tk.setBlockingString("http-failure")
tk.setBlockingString("tcp_ip")
tk.setHTTPExperimentFailure(entry.Failure)
return
}
Expand Down
20 changes: 10 additions & 10 deletions internal/experiment/webconnectivityqa/redirect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
func redirectWithConsistentDNSAndThenConnectionRefusedForHTTP() *TestCase {
return &TestCase{
Name: "redirectWithConsistentDNSAndThenConnectionRefusedForHTTP",
Flags: 0,
Flags: TestCaseFlagNoV04,
Input: "https://bit.ly/32447",
Configure: func(env *netemx.QAEnv) {

Expand Down Expand Up @@ -39,7 +39,7 @@ func redirectWithConsistentDNSAndThenConnectionRefusedForHTTP() *TestCase {
XDNSFlags: 0,
XBlockingFlags: 2, // AnalysisBlockingFlagTCPIPBlocking
Accessible: false,
Blocking: "http-failure",
Blocking: "tcp_ip",
},
}
}
Expand All @@ -49,7 +49,7 @@ func redirectWithConsistentDNSAndThenConnectionRefusedForHTTP() *TestCase {
func redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS() *TestCase {
return &TestCase{
Name: "redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS",
Flags: 0,
Flags: TestCaseFlagNoV04,
Input: "https://bit.ly/21645",
Configure: func(env *netemx.QAEnv) {

Expand Down Expand Up @@ -77,7 +77,7 @@ func redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS() *TestCase {
XDNSFlags: 0,
XBlockingFlags: 2, // AnalysisBlockingFlagTCPIPBlocking
Accessible: false,
Blocking: "http-failure",
Blocking: "tcp_ip",
},
}
}
Expand Down Expand Up @@ -125,7 +125,7 @@ func redirectWithConsistentDNSAndThenConnectionResetForHTTP() *TestCase {
func redirectWithConsistentDNSAndThenConnectionResetForHTTPS() *TestCase {
return &TestCase{
Name: "redirectWithConsistentDNSAndThenConnectionResetForHTTPS",
Flags: 0,
Flags: TestCaseFlagNoV04,
Input: "https://bit.ly/21645",
Configure: func(env *netemx.QAEnv) {

Expand Down Expand Up @@ -153,7 +153,7 @@ func redirectWithConsistentDNSAndThenConnectionResetForHTTPS() *TestCase {
XDNSFlags: 0,
XBlockingFlags: 4, // AnalysisBlockingFlagTLSBlocking
Accessible: false,
Blocking: "http-failure",
Blocking: "tls",
},
}
}
Expand Down Expand Up @@ -232,7 +232,7 @@ func redirectWithConsistentDNSAndThenEOFForHTTP() *TestCase {
func redirectWithConsistentDNSAndThenEOFForHTTPS() *TestCase {
return &TestCase{
Name: "redirectWithConsistentDNSAndThenEOFForHTTPS",
Flags: 0,
Flags: TestCaseFlagNoV04,
Input: "https://bit.ly/21645",
Configure: func(env *netemx.QAEnv) {

Expand Down Expand Up @@ -260,7 +260,7 @@ func redirectWithConsistentDNSAndThenEOFForHTTPS() *TestCase {
XDNSFlags: 0,
XBlockingFlags: 4, // AnalysisBlockingFlagTLSBlocking
Accessible: false,
Blocking: "http-failure",
Blocking: "tls",
},
}
}
Expand Down Expand Up @@ -309,7 +309,7 @@ func redirectWithConsistentDNSAndThenTimeoutForHTTP() *TestCase {
func redirectWithConsistentDNSAndThenTimeoutForHTTPS() *TestCase {
return &TestCase{
Name: "redirectWithConsistentDNSAndThenTimeoutForHTTPS",
Flags: 0,
Flags: TestCaseFlagNoV04,
Input: "https://bit.ly/21645",
LongTest: true,
Configure: func(env *netemx.QAEnv) {
Expand Down Expand Up @@ -338,7 +338,7 @@ func redirectWithConsistentDNSAndThenTimeoutForHTTPS() *TestCase {
XDNSFlags: 0,
XBlockingFlags: 4, // AnalysisBlockingFlagTLSBlocking
Accessible: false,
Blocking: "http-failure",
Blocking: "tls",
},
}
}
3 changes: 2 additions & 1 deletion internal/experiment/webconnectivityqa/tlsblocking.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
func tlsBlockingConnectionResetWithConsistentDNS() *TestCase {
return &TestCase{
Name: "tlsBlockingConnectionResetWithConsistentDNS",
Flags: TestCaseFlagNoV04,
Input: "https://www.example.com/",
Configure: func(env *netemx.QAEnv) {

Expand All @@ -31,7 +32,7 @@ func tlsBlockingConnectionResetWithConsistentDNS() *TestCase {
XStatus: 8448, // StatusExperimentHTTP | StatusAnomalyReadWrite
XBlockingFlags: 4, // AnalysisBlockingFlagTLSBlocking
Accessible: false,
Blocking: "http-failure",
Blocking: "tls",
},
}
}
Expand Down