This repository was archived by the owner on Dec 25, 2024. It is now read-only.
Fix broken SLUB and SISIS Tests after Mockito update#639
Merged
raphaelm merged 2 commits intoopacapp:masterfrom Jun 25, 2021
Merged
Fix broken SLUB and SISIS Tests after Mockito update#639raphaelm merged 2 commits intoopacapp:masterfrom
raphaelm merged 2 commits intoopacapp:masterfrom
Conversation
After update of Mockito from 1.10.19 to 3.8.0 (see 11833f3) custom implementations of ArgumentMatcher did no longer compile. This was fixed following the migration guide in https://www.javadoc.io/doc/org.mockito/mockito-core/3.8.0/org/mockito/ArgumentMatcher.html
After update of Mockito from 1.10.19 to 3.8.0 (see 11833f3) testLoadPages did no longer compile as getArgumentAt was removed in Mockito 2.7.6 (see mockito/mockito#945). Fixed by replacing with getArgument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update of Mockito from
1.10.19to3.8.0in 11833f3 broke a number of tests, see #638. I fixed the tests for the APIs I use (SLUB and SISIS).The are still failing test in BiBer1992AccountTest, BibliothecaAccountTest and VuFindAccountTest but I'm not familiar with these APIs so I didn't try to fix the failing tests. These failures seem to be related to the
jsoupupdate, see #584.