Conversation
staceybeard
reviewed
Jan 31, 2025
| needs: | ||
| - lint | ||
| steps: | ||
| - uses: actions/checkout@v4.2.2 |
Member
There was a problem hiding this comment.
Should this step have a name, like the checkout step above?
Same question for one of the other steps below that doesn't have a name.
Member
Author
There was a problem hiding this comment.
It's not required, it will then say "Run actions/checkout@v4.2.2".
Member
There was a problem hiding this comment.
Ok, I leave it up to you then.
Member
Author
There was a problem hiding this comment.
I removed names where it is obvious (when reusing an action).
staceybeard
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GitHub Actions workflow for CI.
The importer produced the following workflow:
docs.yml
I decided to split this up into two jobs:
lintandbuildand use a workflow that I have used for a personal project withuv.