feat: add scenario column to custom_costs.csv #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgilon
reviewed
Jan 9, 2026
Member
There was a problem hiding this comment.
Looks good tks @daniel-rdt , let's upstream this once we have a final version
| "discount rate": 0.07 | ||
| "standing losses": 0 | ||
| custom_cost_fn: data/custom_costs.csv | ||
| custom_cost_scn: default |
Member
There was a problem hiding this comment.
I think I would prefer this
Suggested change
| custom_cost_scn: default | |
| custom_cost_scenario: all |
| custom_costs_fn : str, optional | ||
| Custom cost modifications file path (default None). | ||
| custom_cost_scn : str, optional | ||
| Custom cost scenario to select in custom cost modification file (default ""). |
Member
There was a problem hiding this comment.
Suggested change
| Custom cost scenario to select in custom cost modification file (default ""). | |
| Custom cost scenario to select in custom cost modification file (default "all"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315.
Changes proposed in this Pull Request
This PR proposes to add a scenario column to the
custom_costs.csvfile which can now also be used to handle scenario management via the newcosts:custom_cost_scnconfig parameter. The default behaviour remains unchanged, however, one now needs to specify an empty string for the case that thecustom_costs.csvfile should be ignored.As for other attributes in
custom_costs.csv, specifying "all" leads to the entry being applied independent of the scenario.Tasks
Workflow
costs:custom_cost_scnwhich is added also as a param to theprocess_cost_datarulecustom_costs.csvare applied for the given scenario and for "all". If empty string ("") is given, no custom_costs are applied.Open issues
Notes
Checklist
config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.doc/release_notes.rstis added.