Conversation
Member
bparks13
commented
Jul 9, 2025
bparks13
commented
- Fixes Rename connect button to "Scan Ports" #106
jonnew
reviewed
Jul 9, 2025
| connectButton->setClickingTogglesState(true); | ||
| connectButton->setToggleState(false, dontSendNotification); | ||
| connectButton->setTooltip("Press to connect or disconnect from Onix hardware"); | ||
| connectButton->setTooltip("Press to scan ports or disconnect from Onix hardware"); |
Contributor
There was a problem hiding this comment.
Press to scan ports or to power off currently connected headstages?
Member
Author
There was a problem hiding this comment.
@jonnew That could work, should I update the button at all? Currently it says "Scan Ports" or "Disconnect", should the second text read as "Power Off"? I'm pretty sure that this would require increasing the size of the button to make sure that the text is all visible.
Contributor
|
We should discuss this more after addressing #112 . If we go the route proposed in that issue, then this might be a bad change to make. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.