Corrects the output to be PCIe host

[bparks13]

This PR modifies the console output to correctly identify the PCIe Host firmware version. Previously it was reported as the breakout board, which was incorrect.

Fixes #150

[cjsha]

I think in the future, we want to refer to the ONIX PCIe card as the ONIX Controller and the host is the computer where the controller is plugged in. This is my understanding from this issue in the onix-docs anyway. I suspect we should go with the nomenclature indicated in that issue.

In line with one of the comments you deleted in the PR, you can probably delete the comment on this line as well:

onix-source/Source/OnixSource.cpp

Line 339 in 2b64b71

if (hubId == ONIX_HUB_FMCHOST) // NB: Breakout Board

I guess it's not necessary to check the breakout's firmware for compatibility? only the controller's firmware?

I'll approve this PR, but please consider these comments and make the appropriate changes before merging. Feel free to re-request a review from me if you want me to take another look.

[bparks13]

@cjsha you bring up a good point about the PCIe card vs. Controller issue, I was using the ONIX docs as a reference, but we want to change that nomenclature in the future. We will have to keep an eye on it so we can change the terminology here when it is updated in the docs.

Good catch with the other comment! I totally missed that

We should add checks for all hardware, in fact it is quite similar to what we recently merged with the Onix1 library where we enforce a minimum version in all devices, since there is an implicit version we are developing against we should instead make it explicit.

[ChucklesOnGitHub]

I guess it's not necessary to check the breakout's firmware for compatibility? only the controller's firmware?

@cjsha @bparks13 sorry for butting in, is it possible to check the breakout board firmware? I thought it wasn't reported by the hardware. If it were, it would be easier to perform the bb firmware updates and troubleshoot with users. that's why i'm interested in knowing, thks!

[bparks13]

@ChucklesOnGitHub I have created a separate issue here to add the version check, as it is something we recently added to the Onix1 library and would be a good addition here as well. If you would like anything specific, such as logging these device firmware versions to the console, please feel free to write them up in that issue so I can track it and make sure to implement everything we need!