feat: Add FLAGD_STREAM_DEADLINE_MS parameter

[marcozabel]

This PR

Is adding the stream deadline parameter to the gRPC channel.

Related Issues

Parent: #1096
Sub: #1287

Notes

Follow-up Tasks

How to test

[gemini-code-assist]

Summary of Changes

Hello @marcozabel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flagd provider by introducing a configurable stream deadline for gRPC connections. This change allows users to specify a timeout for streaming operations, which can improve the stability and resilience of the application by preventing indefinite waits on unresponsive streams. It provides greater control over network behavior and resource management within the gRPC client.

Highlights

• New Configuration Parameter: Introduced FLAGD_STREAM_DEADLINE_MS to control the deadline for gRPC streaming connections, allowing customization of the timeout for long-lived connections.
• Environment Variable Support: The new streamDeadlineMs parameter can be configured via the FLAGD_STREAM_DEADLINE_MS environment variable, providing flexibility in deployment.
• gRPC Service Integration: The GRPCService now utilizes the configured streamDeadlineMs instead of a hardcoded Infinity when watching channel connectivity state, enabling proper timeout management for streams.
• Default Value: A default value of 600000 milliseconds (10 minutes) has been set for streamDeadlineMs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new configuration parameter, FLAGD_STREAM_DEADLINE_MS, to control the deadline for gRPC streaming connections. The changes correctly add this parameter to the configuration, tests, and apply it in the gRPC service.

My review identifies one issue in libs/providers/flagd/src/lib/configuration.ts where the logic for parsing numeric environment variables is flawed. It fails to handle the value '0' correctly. I've provided a suggestion to fix this, which also improves efficiency by avoiding redundant operations. This issue is present for other numeric parameters as well, and the suggested pattern can be applied to them for consistency and correctness.