Skip to content

Conversation

@imsingh
Copy link

@imsingh imsingh commented Dec 19, 2025

This PR

Enables the e2e tests for metadata for flagd provider

Related Issues

#1290

Fixes #1290

How to test

npm run e2e

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @imsingh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables comprehensive end-to-end testing for metadata functionality within the flagd provider. It achieves this by implementing the necessary Gherkin step definitions to parse and assert flag metadata values, and by configuring the test runners to include previously excluded metadata-related scenarios for both in-process and RPC test environments.

Highlights

  • Metadata Test Step Implementation: The then('the resolved metadata should contain', ...) and then('the resolved metadata is empty', ...) Gherkin steps have been fully implemented in flagSteps.ts to assert flag metadata values, including type conversion for Integer, Float, Boolean, and String types.
  • Metadata Provider Type Support: A new 'metadata' case has been added to the provider type switch in providerSteps.ts, allowing the test suite to configure the flagd provider specifically for metadata-related scenarios.
  • Enabled Metadata E2E Tests: The @metadata tag has been removed from the exclusion list in the tagFilter for both in-process.spec.ts and rpc.spec.ts, enabling the execution of end-to-end tests for metadata functionality in these test suites.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables e2e tests for metadata in the flagd provider. The changes look good, primarily involving the implementation of test steps for metadata validation and updating test configurations to include metadata tests. I have one suggestion to improve code maintainability by reducing duplication.

Signed-off-by: Indermohan Singh <indermohansinghk7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flagd] enable metadata tests

4 participants