Skip to content

Conversation

@marcozabel
Copy link
Contributor

@marcozabel marcozabel commented Dec 19, 2025

This PR

This PR is adding evaluation options to the FeatureFlag component to allow the use of suspend options.

Related Issues

#1321

Notes

Follow-up Tasks

How to test

Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
@marcozabel marcozabel requested review from a team as code owners December 19, 2025 13:51
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @marcozabel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the FeatureFlag component by introducing an evaluationOptions prop. This addition allows developers to pass specific evaluation configurations, such as suspend options, directly to the component. This is particularly useful for integrating feature flag evaluations with React's Suspense, enabling the display of loading states while flags are being resolved asynchronously, thereby improving the user experience during feature flag evaluation.

Highlights

  • FeatureFlag Component Enhancement: The FeatureFlag component now accepts an evaluationOptions prop, allowing for more granular control over flag evaluation behavior.
  • Suspense Integration: The added evaluationOptions are passed directly to the underlying useFlag hook, enabling the use of suspend options for better integration with React's Suspense mechanism.
  • New Test Cases: New tests have been introduced to verify the FeatureFlag component's behavior when suspend: true is used, ensuring that fallbacks are rendered correctly during asynchronous flag resolution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds evaluationOptions to the FeatureFlag component, allowing consumers to pass options like suspend to the underlying useFlag hook. The changes are well-implemented and include tests for the new suspense functionality. I've made a couple of suggestions to improve the test code's robustness and clarity. Overall, this is a good addition.

Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Copy link
Contributor

@weyert weyert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants