Skip to content

Conversation

@SrideviRamesh
Copy link

Signed-off-by: Sridevi Ramesh sridevra@in.ibm.com

Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>
@ruscur
Copy link
Collaborator

ruscur commented Oct 9, 2019

Can one of the admins verify this patch?

Copy link
Contributor

@oohal oohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more specific about what is being tested here?

@SrideviRamesh
Copy link
Author

Adding test scenario for POWER 9.. existing code has only test scenarios for p8 platform

@oohal
Copy link
Contributor

oohal commented Oct 10, 2019

Adding test scenario for POWER 9.. existing code has only test scenarios for p8 platform

That is completely unhelpful. What is the scenario being tested?

Copy link

@hegdevasant hegdevasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this patch? It doesn't pass sanity tests for me.

======================================================================
ERROR: runTest (testcases.OpTestPrdDriver.OpTestPrdDriver)

Traceback (most recent call last):
File "/op-test/testcases/OpTestPrdDriver.py", line 295, in runTest
self.prd_test_core_fir(e.FIR, e.FIMR, e.ERROR)
File "/op-test/testcases/OpTestPrdDriver.py", line 137, in prd_test_core_fir
log.debug("OPAL-PRD: Injecting error 0x%x on FIR: %s" % (ERROR, FIR))
TypeError: %x format: an integer is required, not str


Ran 1 test in 25.115s

-Vasant

@PraveenPenguin PraveenPenguin force-pushed the master branch 2 times, most recently from 4d0cb14 to b976629 Compare October 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants