-
Notifications
You must be signed in to change notification settings - Fork 38
Support derandomized key generation for ML-KEM #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+120
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
jimouris
approved these changes
Mar 19, 2025
Member
jimouris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dstebila
approved these changes
Mar 19, 2025
AdijeShen
pushed a commit
to AdijeShen/liboqs-java
that referenced
this pull request
Mar 23, 2025
* Support derandomized key generation for ML-KEM Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> * Update example output in README.md Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> --------- Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Adije Shen <1534656015@qq.com>
SWilson4
added a commit
that referenced
this pull request
Jun 13, 2025
* [build] use .a of liboqs Signed-off-by: Adije Shen <1534656015@qq.com> * [3rd] add link to liboqs Signed-off-by: Adije Shen <1534656015@qq.com> * mv liboqs as a submodule Signed-off-by: Adije Shen <1534656015@qq.com> * [doc] update the doc Signed-off-by: Adije Shen <1534656015@qq.com> * unify windows and unix operation Signed-off-by: Adije Shen <1534656015@qq.com> * add guide for windows Signed-off-by: Adije Shen <1534656015@qq.com> * Update README.md Signed-off-by: Huajie Shen <1534656015@qq.com> Signed-off-by: Adije Shen <1534656015@qq.com> * keep the origin README file format Signed-off-by: Adije Shen <1534656015@qq.com> * Update README Signed-off-by: Adije Shen <1534656015@qq.com> * Add RELEASE.md Signed-off-by: Huajie Shen <1534656015@qq.com> Signed-off-by: Adije Shen <1534656015@qq.com> * delete gitmodules Signed-off-by: Adije Shen <1534656015@qq.com> * Move CI to GitHub Actions (#30) * Port workflows from CircleCI to GitHub Actions * Add CI job for workflow linting * Update README badge --------- Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Adije Shen <1534656015@qq.com> * Add support for the ML-DSA Context (#31) Signed-off-by: John Gray <john.gray@entrust.com> Signed-off-by: Adije Shen <1534656015@qq.com> * Update README, examples, and CI before 0.2.0 release (#32) * Update to latest CI image Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> * Install jdk package and set JAVA_HOME Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> * Add macOS job Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> * Update README.md and example files Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> * Remove unnecessary install Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> --------- Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> * Support derandomized key generation for ML-KEM (#33) * Support derandomized key generation for ML-KEM Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> * Update example output in README.md Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> --------- Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: Adije Shen <1534656015@qq.com> * add back the windows installation guide Signed-off-by: Adije Shen <1534656015@qq.com> * merge Signed-off-by: adijeshen <1534656015@qq.com> * add windows CI Signed-off-by: adijeshen <1534656015@qq.com> * change CI Signed-off-by: root <root@adijethinkbook.> Signed-off-by: Adije Shen <1534656015@qq.com> * Update README.md Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> --------- Signed-off-by: Adije Shen <1534656015@qq.com> Signed-off-by: Huajie Shen <1534656015@qq.com> Signed-off-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Signed-off-by: John Gray <john.gray@entrust.com> Signed-off-by: adijeshen <1534656015@qq.com> Signed-off-by: root <root@adijethinkbook.> Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca> Co-authored-by: John Gray <55205977+johngray-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the new API function added in open-quantum-safe/liboqs#2070.
I also updated the example outputs in the README to reflect a new KEM structure field (
length_keypair_seed) as well as new signature algorithms (UOV).