Closed
Conversation
- add detailed xml declaration - make fixture attributes of BaseChildNode optional - make matrix of layer, groupobject, geometry3d and symbol optional. - (Usually only one object has a matrix, mostly scene object, truss, etc) - add Geometry3D to ChildList - add ChildList to Symdef
- If matrix is identity it will not be added to xml. - Add better matrix check - Reformated with ruff
Collaborator
So i think we should be good here, hope i understood it all correctly. After i finish all work related to your code and our code, please let me know if all works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.