feat(lambda): read cloud.account.id from symlink in Lambda detector#2619
Draft
RaphaelManke wants to merge 3 commits intoopen-telemetry:mainfrom
Draft
feat(lambda): read cloud.account.id from symlink in Lambda detector#2619RaphaelManke wants to merge 3 commits intoopen-telemetry:mainfrom
RaphaelManke wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
…ector Read /tmp/.otel-account-id via Files.readSymbolicLink in LambdaResource and set cloud.account.id resource attribute. Silently skips if the symlink does not exist or readlink is unsupported. Preserves leading zeros by treating the value as a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud.account.idfrom the symlink at/tmp/.otel-account-idcreated by the OTel Lambda ExtensionFiles.readSymbolicLink()to read the symlink targetcatch (IOException | UnsupportedOperationException)if the symlink doesn't existDepends on
Changes
LambdaResource.java— Added readlink logic withACCOUNT_ID_SYMLINK_PATHconstant, injectablePathfor testingLambdaResourceTest.java— Happy path, missing symlink, leading zeros testsTest plan
cloud.account.idset correctly