Skip to content

Add log message when fsspec cannot be imported.. #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DylanRussell wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −0
Open

Add log message when fsspec cannot be imported.. #4037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50d964a
Add log message
DylanRussell Dec 16, 2025
7c2be23
Merge branch 'main' into add_err_log
DylanRussell Dec 23, 2025
48e0456
Add changelog, adjust err msg
DylanRussell Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions util/opentelemetry-util-genai/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

- Log error when `fsspec` fails to be imported instead of silently failing ([#4037](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4037)).
- Minor change to check LRU cache in Completion Hook before acquiring semaphore/thread ([#3907](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3907)).
- Add environment variable for genai upload hook queue size
([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3943](#3943))
Expand Down
3 changes: 3 additions & 0 deletions util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ def upload_completion_hook() -> CompletionHook:
UploadCompletionHook,
)
except ImportError:
_logger.exception(
"Failed to import `fsspec`. Falling back to `NoOpCompletionHook`."
)
return _NoOpCompletionHook()

environ_max_queue_size = environ.get(
Expand Down
Loading