Open
Conversation
thompson-tomo
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
github-actions
bot
assigned
indrekj,
jj22ee,
MikeGoldsmith,
muripic,
NathanielRN,
robbkidd,
robertlaurin and
scbjans
Contributor
|
We have not committed lock files in the past because they are regenerated in CI with each Ruby version that may have a different installed bundler version and gem requirements. I am concerned about the conflicts we used to run into will pop-up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1962
This goes through and commits the gem lockfiles.
By committing the lockfiles this enables the fossa scan to be simplified to only upload pre-generated files rather than needing to generate them on the go. It also enables better deterministic builds as everyone will always be using the same lock file.
We do not need to worry about maintaining the lockfile as renovate will raise a weekly pr to bump the contents.
Note i have also scheduled a weekly upload of the files to fossa.