Implement lazily converted wrapper types phase one: strings#456
Draft
andrewparmet wants to merge 3 commits intoopen-toast:mainfrom
Draft
Implement lazily converted wrapper types phase one: strings#456andrewparmet wants to merge 3 commits intoopen-toast:mainfrom
andrewparmet wants to merge 3 commits intoopen-toast:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begins implementation of replacing naive, eagerly converted wrapped fields with a deferred, lazy implementation. The runtime API introduced in this PR is not the final API, which will be change in a follow-up that generalizes this pattern to all wrapper types; this PR is just the minimal proof-of-concept.
A comparison of generated code:
Before:
After:
Key differences:
Benchmark Results: Baseline (main) vs Caching String Fields
Key findings: