zblue: propagate headers to libbluetooth via nuttx_link_libraries. #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengkai15
reviewed
Feb 3, 2026
|
|
||
| target_link_libraries(zblue PRIVATE zblue_headers) | ||
| # PUBLIC so dependents (e.g. libbluetooth via nuttx_add_dependencies + nuttx_link_libraries) get INTERFACE include dirs | ||
| target_link_libraries(zblue PUBLIC zblue_headers) |
Contributor
There was a problem hiding this comment.
why change from PRIVATE to PUBLIC ？
Contributor
Author
There was a problem hiding this comment.
PUBLIC propagates INTERFACE to dependents; PRIVATE keeps headers internal.
chengkai15
reviewed
Feb 3, 2026
zblue/CMakeLists.default.txt
Outdated
| ${SYS_COMPAT_DIR} | ||
| ${ZBLUE_DIR}/port/include/zephyr | ||
| ${ZBLUE_DIR}/port/include | ||
| ${ZBLUE_DIR}/include/zephyr/sys |
Contributor
There was a problem hiding this comment.
was the sys head in port missing？
Contributor
|
Hi @xuxin930 帮忙 review 一下 |
xuxin930
approved these changes
Feb 3, 2026
zhongzhijie1
approved these changes
Feb 3, 2026
chengkai15
approved these changes
Feb 3, 2026
bug: v/85506 Add Zephyr sys/settings include paths and link zblue to zblue_headers with PUBLIC so dependents like libbluetooth get include dirs via nuttx_link_libraries. Reorder include dirs for host/keys.h and settings_zblue.h. Signed-off-by: v-yichenxi <v-yichenxi@xiaomi.com>
huangyulong3
approved these changes
Feb 5, 2026
GUIDINGLI
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/85506
Add Zephyr sys/settings include paths and link zblue to zblue_headers with PUBLIC so dependents like libbluetooth get include dirs via nuttx_link_libraries. Reorder include dirs for host/keys.h and settings_zblue.h.