Bugfix/fix bluetooth bt tool hfp ag moudle cb change to const

[huangyulong3]

Memory Optimization: Change the bluetooth bt_tool hfp ag module to const for reduce the ram size.

bug:v/84972

Rootcause: To reduce RAM resource consumption, the g_hfp_ag_tables,
in the bt_tools hfp ag module must be marked with the const modifier.
This ensures it is compiled and linked into Flash memory instead of RAM.

[Copilot]

Pull request overview

This PR optimizes RAM usage by converting static data structures in the Bluetooth tools and service layers to const, enabling them to be stored in Flash memory rather than RAM. The PR addresses bug v/84972 by systematically adding the const modifier to command tables, callback structures, and GATT attribute databases across the codebase.

Changes:

• Marked static callback structures and command tables as const across tools/ and service/ directories
• Added explicit casts when passing const pointers to APIs that don't have const-correct signatures
• Added forward declarations in sal_adapter_le_interface.c for organizational purposes

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/hfp_ag.c	Made g_hfp_ag_tables const with cast at call site
tools/gatt_server.c	Made attribute databases and command tables const with casts
tools/gatt_client.c	Made g_gattc_tables and gattc_cbs const with casts
tools/bt_tools.c	Made multiple command tables and option arrays const with casts
tools/async/scan.c	Made scan_options and g_scanner_async_tables const with cast
tools/async/log.c	Made g_log_async_tables const with cast
tools/async/gatt_client.c	Made g_gattc_async_tables and gattc_cbs const with casts
tools/async/gap.c	Made multiple command and option tables const with casts
tools/async/adv.c	Made advertising tables and callbacks const with casts
tools/adv.c	Made advertising tables and callbacks const with casts
tools/a2dp_source.c	Made g_a2dp_tables const with cast
service/stacks/zephyr/sal_spp_interface.c	Made SDP attributes and RFCOMM ops const with casts
service/stacks/zephyr/sal_hid_device_interface.c	Made HID attributes and callbacks const with casts
service/stacks/zephyr/sal_hfp_hf_interface.c	Made HFP HF callbacks const with cast
service/stacks/zephyr/sal_hfp_ag_interface.c	Made HFP AG callbacks const with cast
service/stacks/zephyr/sal_avrcp_interface.c	Made AVRCP target callbacks const
service/stacks/zephyr/sal_adapter_le_interface.c	Made LE connection and auth callbacks const with casts, added forward declarations
service/stacks/zephyr/sal_adapter_interface.c	Made BR/EDR adapter callbacks const with casts
service/stacks/zephyr/sal_a2dp_interface.c	Made A2DP codec config and callbacks const with casts
service/profiles/spp/spp_service.c	Made SPP interface const
service/profiles/hid/hid_device_service.c	Made HID device interface const
service/ipc/socket/src/bt_socket_spp.c	Made SPP socket callbacks const with cast
service/ipc/socket/src/bt_socket_scan.c	Made scanner socket callbacks const with cast
service/ipc/socket/src/bt_socket_advertiser.c	Made advertiser socket callbacks const with cast
framework/btwrap/async/bt_gatt_feature.c	Made feature GATT client callbacks const with cast
feature/feature_async/src/bluetooth_ble_impl.c	Made advertiser callbacks and GATT client callbacks const with casts

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Casting away const is a workaround that indicates the function signature for execute_command_in_table should accept a const pointer. Since the function only reads from the table (iterating through it to find matching commands), the parameter should be declared as const bt_command_t*. This would eliminate the need for this cast and improve type safety throughout the codebase.

Suggested change

	ret = execute_command_in_table(handle, (bt_command_t *)g_hfp_ag_tables, ARRAY_SIZE(g_hfp_ag_tables), argc, argv);
	ret = execute_command_in_table(handle, g_hfp_ag_tables, ARRAY_SIZE(g_hfp_ag_tables), argc, argv);

[Copilot]

Casting away const is a workaround that indicates the bt_gattc_create_connect function signature should accept a const pointer for callbacks. Since callbacks are only stored and invoked (not modified), the API should be updated to accept const gattc_callbacks_t*. This pattern appears in the binder code where callbacks are already stored as const, suggesting this is the intended design.

[Copilot]

Casting away const to assign to a Zephyr API structure field. This is a pragmatic workaround since the underlying Zephyr bt_rfcomm_dlc structure doesn't use const-qualified pointers for ops. While the callbacks are not modified in practice, this cast technically invokes undefined behavior per the C standard if the underlying library were to modify these callbacks. Consider working with the Zephyr project to add const-correctness to their API signatures.