Bugfix/fix bluetooth bt tool hid device moudle cb change to const

[huangyulong3]

Memory Optimization: Change the bluetooth bt_tool hid device module to const for reduce the ram size.

bug:v/84974

Rootcause: To reduce RAM resource consumption, the g_hidd_tables,
in the bt_tools hid device module must be marked with the const modifier.
This ensures it is compiled and linked into Flash memory instead of RAM.

[Copilot]

Pull request overview

This PR implements a memory optimization by converting static data structures from RAM to Flash memory by adding the const qualifier. The primary goal is to reduce RAM resource consumption across the Bluetooth tool and service modules.

Changes:

• Added const qualifier to static command tables (bt_command_t arrays) and option structures (struct option arrays) across multiple tool files
• Added const qualifier to static callback structures (gattc_callbacks_t, advertiser_callback_t, etc.) in service layer files
• Added explicit casts (type *) when passing const-qualified structures to APIs that expect non-const pointers
• Added forward declarations in sal_adapter_le_interface.c

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tools/hid_device.c	Made g_hidd_tables const and added cast when passing to execute_command_in_table
tools/hfp_hf.c	Made g_hfp_tables const and added cast when passing to execute_command_in_table
tools/hfp_ag.c	Made g_hfp_ag_tables const and added cast when passing to execute_command_in_table
tools/gatt_server.c	Made attribute database arrays and command table const, added casts in service database structures
tools/gatt_client.c	Made g_gattc_tables and gattc_cbs const, added casts when registering callbacks
tools/bt_tools.c	Made multiple command tables and option structures const, added casts in execute calls
tools/async/scan.c	Made scan option and command tables const, added casts
tools/async/log.c	Made log command table const, added cast
tools/async/gatt_client.c	Made command table and callbacks const, added casts
tools/async/gap.c	Made multiple command tables and option structures const, added casts
tools/async/adv.c	Made advertising option and command tables and callbacks const, added casts
tools/adv.c	Made advertising option and command tables and callbacks const, added casts
tools/a2dp_source.c	Made command table const, added cast
service/stacks/zephyr/sal_spp_interface.c	Made SDP attributes and RFCOMM ops const, added casts
service/stacks/zephyr/sal_hid_device_interface.c	Made SDP attributes and HID callbacks const, added casts
service/stacks/zephyr/sal_hfp_hf_interface.c	Made HFP HF callbacks const, added cast
service/stacks/zephyr/sal_hfp_ag_interface.c	Made HFP AG callbacks const, added cast
service/stacks/zephyr/sal_avrcp_interface.c	Made AVRCP target callbacks const
service/stacks/zephyr/sal_adapter_le_interface.c	Made LE connection callbacks const, added casts and forward declarations
service/stacks/zephyr/sal_adapter_interface.c	Made BR/EDR connection callbacks const, added casts
service/stacks/zephyr/sal_a2dp_interface.c	Made A2DP codec info and callbacks const, added casts
service/profiles/spp/spp_service.c	Made SPP interface structure const
service/profiles/hid/hid_device_service.c	Made HID device interface structure const
service/ipc/socket/src/bt_socket_spp.c	Made SPP socket callbacks const, added cast
service/ipc/socket/src/bt_socket_scan.c	Made scanner socket callbacks const, added cast
service/ipc/socket/src/bt_socket_advertiser.c	Made advertiser socket callbacks const, added cast
framework/btwrap/async/bt_gatt_feature.c	Made GATT feature callbacks const, added cast
feature/feature_async/src/bluetooth_ble_impl.c	Made advertiser and GATT client callbacks const, added casts

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The memory optimization is incomplete. Several tool files with the same bt_command_t table pattern were not updated to use const:

• tools/a2dp_sink.c: g_a2dp_sink_tables
• tools/avrcp_control.c: g_avrcp_control_tables
• tools/l2cap.c: g_l2cap_commands
• tools/lea_*.c: Multiple LEA-related command tables
• tools/log.c: g_log_tables
• tools/panu.c: g_pan_tables
• tools/scan.c: g_scanner_tables
• tools/spp.c: g_spp_tables
• tools/storage_update/storage_tool.c: g_storage_tables
• tools/async/gap.c: g_async_cmd_tables

These should be made const with corresponding casts in execute_command_in_table calls for consistency and to maximize RAM savings.

[Copilot]

The memory optimization is incomplete for option structures. Several files with struct option arrays were not updated to use const:

• tools/bt_tools.c: main_options
• tools/scan.c: scan_options
• tools/spp.c: spp_ping_options
• tools/storage_update/storage_tool.c: set_options, delete_options

These should be made const for consistency and to maximize RAM savings, similar to the changes made to le_conn_options, adv_options, adv_stop_options, and scan_options in other files.

[Copilot]

Casting away const and passing the pointer to a function expecting non-const is technically undefined behavior in C if the function modifies the data. While the current implementation may not modify these structures, this creates a maintenance risk: if the API implementation changes in the future to modify these structures, it would result in undefined behavior.

A safer approach would be to:

1. Update the API signatures to accept const pointers (e.g., const bt_command_t*, const gattc_callbacks_t*, etc.) if these structures are truly not modified
2. Or, keep the structures non-const if they need to be modifiable

The current approach trades type safety for memory optimization, which may be acceptable for embedded systems with tight memory constraints, but should be documented clearly.

Suggested change

	ret = execute_command_in_table(handle, (bt_command_t *)g_hidd_tables, ARRAY_SIZE(g_hidd_tables), argc, argv);
	ret = execute_command_in_table(handle, g_hidd_tables, ARRAY_SIZE(g_hidd_tables), argc, argv);

[Copilot]

The forward declarations for le_conn_add and le_conn_find added on lines 110-111 appear unnecessary. These functions are not referenced by the g_conn_cbs structure below, and forward declarations are only needed when there's a dependency. Unless these functions reference the const structures above them in a way that creates a circular dependency, these forward declarations can be removed.

Suggested change

	static le_conn_info_t* le_conn_add(const bt_address_t* addr);
	static le_conn_info_t* le_conn_find(const bt_address_t* addr);

[Copilot]

The PR title mentions only "hid device module" but the changes affect many more modules including hfp_hf, hfp_ag, gatt_server, gatt_client, bt_tools, adv, scan, log, spp, a2dp, avrcp, and various service stack and IPC files. The title should be updated to reflect the broader scope of changes, for example: "Memory optimization: Make static data structures const across bluetooth tools and services"

[Copilot]

The PR title contains a typo: "moudle" should be "module".