SPP: add credits control for recv data #451
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengkai15
requested review from
gzh-terry,
huangyulong3,
hyson710,
zhangyuan376 and
zhongzhijie1
as code owners
huangyulong3
reviewed
Feb 8, 2026
|
|
||
| spp_conn_unlock(); | ||
|
|
||
| bt_rfcomm_dlc_update_credits(&spp_conn->rfcomm_dlc); |
There was a problem hiding this comment.
When the underlying RFCOMM layer receives a message (rfcomm_recv), it has already updated the credit. Why is it necessary to update the credit again at the SAL layer?
Contributor
Author
There was a problem hiding this comment.
SPP's data flow control is handled in the Bluetooth service, while the HFP module's rfcomm maintains protocol stack flow control.
chengkai15
force-pushed
the
buf_spp_rx
branch
from
e92d430 to
a6a94dd
Compare
gzh-terry
approved these changes
Feb 10, 2026
chejinxian
reviewed
Feb 11, 2026
chengkai15
force-pushed
the
buf_spp_rx
branch
from
a6a94dd to
6b694a7
Compare
chejinxian
approved these changes
Feb 11, 2026
huangyulong3
approved these changes
Feb 11, 2026
huangyulong3
approved these changes
Feb 11, 2026
chengkai15
force-pushed
the
buf_spp_rx
branch
from
6b694a7 to
f017ad0
Compare
bug: v/85608 rootcause: Adding SPP process handling to the bluetooth service resolves the issue of non-flow control data piling up in the protocol stack. Signed-off-by: Kai Cheng <chengkai@xiaomi.com>
bug: v/85788 rootcause: enable spp rx credits mode control, in order to fix HFP/AG not auto credits Signed-off-by: Kai Cheng <chengkai@xiaomi.com>
chengkai15
force-pushed
the
buf_spp_rx
branch
from
f017ad0 to
6ff3d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/85608
rootcause: Adding SPP process handling to the bluetooth service resolves the issue of non-flow control data piling up in the protocol stack.
Summary
Adding SPP process handling to the bluetooth service resolves the issue of non-flow control data piling up in the protocol stack.
Impact
spp rx data
Testing
test spp rx pass