bluetooth: fix adv data parsing for zero-length AD structures #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongzhijie1
requested review from
chengkai15,
gzh-terry,
huangyulong3,
hyson710 and
zhangyuan376
as code owners
huangyulong3
reviewed
Feb 6, 2026
gzh-terry
previously approved these changes
Feb 6, 2026
zhongzhijie1
force-pushed
the
_sal_adv_fix
branch
from
146112e to
369e56b
Compare
zhongzhijie1
force-pushed
the
_sal_adv_fix
branch
from
369e56b to
947a90b
Compare
gzh-terry
approved these changes
Feb 9, 2026
huangyulong3
approved these changes
Feb 9, 2026
chengkai15
approved these changes
Feb 10, 2026
bug: v/85714 The previous implementation did not handle zero-length AD items (len == 0) and lacked sufficient boundary checks. As a result, padding bytes could be misinterpreted as valid AD elements, leading to construction of invalid bt_data entries with oversized data_len values. This could further cause out-of-bounds memory access during advertising data processing in the host stack. This change adds proper handling for zero-length AD items, validates item length and buffer boundaries, and enforces segment count limits to prevent invalid bt_data construction. Signed-off-by: zhongzhijie1 <zhongzhijie1@xiaomi.com>
zhongzhijie1
force-pushed
the
_sal_adv_fix
branch
from
947a90b to
d7f0b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/85714
The previous implementation did not handle zero-length AD items (len == 0) and lacked sufficient boundary checks. As a result, padding bytes could be misinterpreted as valid AD elements, leading to construction of invalid bt_data entries with oversized data_len values.
This could further cause out-of-bounds memory access during advertising data processing in the host stack.
This change adds proper handling for zero-length AD items, validates item length and buffer boundaries, and enforces segment count limits to prevent invalid bt_data construction.