att over br modify patch #458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts limit bug: v/84473 When the number of registered services exceeds the limit, records not captured by `gatt_sdp_records` will be returned. Subsequent attempts to locate pointer indices for release will fail. Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
…`bt_conn_lookup_addr_br`. bug: v/84474 1. Add a call to bt_conn_unref(conn) 2. Use the locally stored conn in the sal layer to avoid executing `bt_conn_unref` Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
bug: v/84474 When the peer initiates a connection, the connection callback reporting logic lacks the `bt_conn_add` entry. This prevents the subsequent SAL layer from retrieving the corresponding `bt_conn_info_t` object for the address, leading to subsequent data transmission process failures. Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
bug: v/84474 When the SAL layer does not store the BREDR connection information, it returns info as NULL. At this point, attempting an erroneous address offset on info->conn will result in a null pointer return. Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
liuX10
requested review from
chengkai15,
gzh-terry,
huangyulong3,
hyson710,
zhangyuan376 and
zhongzhijie1
as code owners
chengkai15
reviewed
Feb 10, 2026
chengkai15
reviewed
Feb 10, 2026
chengkai15
reviewed
Feb 10, 2026
chengkai15
reviewed
Feb 10, 2026
gzh-terry
reviewed
Feb 10, 2026
gzh-terry
reviewed
Feb 10, 2026
gzh-terry
reviewed
Feb 10, 2026
Contributor
zhongzhijie1
left a comment
zhongzhijie1
left a comment
There was a problem hiding this comment.
LGTM. The changes look good and address several issues:
- Memory Management: Fixed potential memory leaks in
gatt_sdp_create_record(freeingattrsandrecordon failure) anddo_gatts_disconnect(addingbt_conn_unref). - Connection Tracking:
zblue_gatts_connected_callbacknow usesbt_conn_addto ensure the connection is tracked and sets theGATT_ROLE_SERVERflag. - ATT over BR/EDR Support: The changes in
send_response,send_notification, andsend_indicationcorrectly implement a fallback to look up BR/EDR connections when an LE connection is not found, which is consistent with the PR title.
chengkai15
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.