Skip to content

Conversation

Copy link

Copilot AI commented Feb 10, 2026

CMakeLists.txt was missing external zblue include paths required by the Zephyr stack adapter, causing compilation failures when CONFIG_BLUETOOTH_STACK_BREDR_ZBLUE or CONFIG_BLUETOOTH_STACK_LE_ZBLUE is enabled.

Changes

  • Added 4 external zblue include directories to match Makefile implementation (lines 278-281)
    • port/include/ - for <zephyr/device.h>, <zephyr/kernel.h>
    • subsys/bluetooth/host - for <zephyr/bluetooth/*.h>
    • subsys/settings/include/settings - for <zephyr/settings/settings.h>
    • port/include/kernel/include - for kernel headers

The zephyr stack adapter files (hci_h4.c, sal_adapter_le_interface.c, etc.) include these headers but the paths were only present in Makefile, not CMakeLists.txt.

if(CONFIG_BLUETOOTH_STACK_BREDR_ZBLUE OR CONFIG_BLUETOOTH_STACK_LE_ZBLUE)
  list(APPEND INCDIR ${BLUETOOTH_DIR}/service/stacks/zephyr/include)
  list(APPEND INCDIR ${NUTTX_APPS_DIR}/external/zblue/zblue/port/include/)
  list(APPEND INCDIR ${NUTTX_APPS_DIR}/external/zblue/zblue/subsys/bluetooth/host)
  list(APPEND INCDIR ${NUTTX_APPS_DIR}/external/zblue/zblue/subsys/settings/include/settings)
  list(APPEND INCDIR ${NUTTX_APPS_DIR}/external/zblue/zblue/port/include/kernel/include)

Follows existing pattern for external dependencies (dbus, glib, bluelet) using ${NUTTX_APPS_DIR}/external/.

Original prompt

review this PR


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: gzh-terry <174715478+gzh-terry@users.noreply.github.com>
Copilot AI changed the title [WIP] Review pull request for code changes Fix missing zblue external include directories in CMake build Feb 10, 2026
Copilot AI requested a review from gzh-terry February 10, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants