Fix Abdera example and add the Cobra convention #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think my implementation is correct, and does fix a few things from the original output.
dagwieers
changed the title
dagwieers
changed the title
Author
|
I discovered that Cobra (Cisco ACI) and Abdera are sufficiently different to warrant adding the Cobra convention too. |
Author
|
@philipashlock Any feedback ? |
Author
|
@philipashlock Can we get this merged ? The output is based on the terrific xmljson python library. |
Author
|
Any feedback on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think my implementation is correct, and does fix a few things from the original output.
Feedback appreciated.