Fix metadata, system user, fix bugs related to argument parser#220
Fix metadata, system user, fix bugs related to argument parser#220qr243vbi wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
0abcb5b to
c438323
Compare
…om archive file, add setopt option
|
This PR is hard to review, there's just one commit with a lot of changes that moves code from |
Writing code is much more difficult than reviewing it, so please look at the code, scrutinize it and ask your questions, I will respond |
|
The description doesn't match with the actual diff in the PR, this PR does a lot of changes in a single commit that hides a big refactoring and does several unrelated changes at the same time so it's hard to tell if it's changing something relevant and can cause unexpected side effects. In addition, the description mentions "fix metadata" and "fix bugs" but it's not clear to me which actual bugs is fixing, there's no link to existing issues or any example of the failure happening when using py2pack to fetch or generate a new spec file. So I'm closing this PR. @qr243vbi if you want to get these changes in the py2pack code, please, try to follow these basic steps:
Here you have some references about how to create a better PR/commit: |
The main purpose of this commit is to fix empty provides_extra field, fix empty user and add ability to show metadata from local package