refactor: made all thread item conversion functions async [N/A]#38
Merged
jiwon-oai merged 1 commit intoopenai:mainfrom Nov 3, 2025
Conversation
Collaborator
|
Thanks for making this change! We will update this in an upcoming minor version release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🆕 This PR allows all handler functions used inside the
ThreadItemConverterto be asynchronous, since currently, some are async while some are not. Since the parent function awaits anyways, there is no apparent reason to not have all of them async, which is something that could be desired by some people.