Skip to content

Make IconName type change backwards compatible #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiwon-oai wants to merge 1 commit into from
Closed

Make IconName type change backwards compatible #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions chatkit/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,8 @@ class CustomSummary(BaseModel):
"""Custom summary for a workflow."""

title: str
icon: IconName | None = None
# IconName is the only supported type but we allow str for backwards compatibility
icon: IconName | str | None = None


class DurationSummary(BaseModel):
Expand Down Expand Up @@ -735,7 +736,8 @@ class CustomTask(BaseTask):

type: Literal["custom"] = "custom"
title: str | None = None
icon: IconName | None = None
# IconName is the only supported type but we allow str for backwards compatibility
icon: IconName | str | None = None
content: str | None = None


Expand Down Expand Up @@ -811,7 +813,8 @@ class EntitySource(SourceBase):

type: Literal["entity"] = "entity"
id: str
icon: IconName | None = None
# IconName is the only supported type but we allow str for backwards compatibility
icon: IconName | str | None = None
preview: Literal["lazy"] | None = None
data: dict[str, Any] = Field(default_factory=dict)

Expand Down