Closed
Conversation
Palen
commented
Dec 3, 2025
- Prevent duplicated reasoning tasks by storing deep copies of newly added items in the streaming pending-items tracker, so _update_pending_items no longer mutates the responder’s original workflow item twice.
- Add regression test test_workflow_updates_not_applied_twice proving a responder that mutates a workflow before emitting updates yields only one reasoning task in both streamed and stored workflow items.
Collaborator
|
Thank you for this and apologies for the belated response! We merged this change in a separate PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.