fix: use merge-base for accurate PR diff in code review example #64
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code review example used base.sha...head.sha which incorrectly shows commits added to main after the PR branch was created as 'removed' when the branch is not up to date with main. This change: - Adds fetch-depth: 0 to get full git history - Computes merge-base to find the common ancestor between PR and base branch - Uses git diff with merge-base to show only changes introduced by the PR This ensures the code review focuses on actual PR changes regardless of whether the branch is up to date with main.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code review example used base.sha...head.sha which incorrectly shows commits added to main after the PR branch was created as 'removed' when the branch is not up to date with main.
This change:
This ensures the code review focuses on actual PR changes regardless of whether the branch is up to date with main.