feat(cryptpilot-convert): skip boot partition creation in UKI mode #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --uki is specified, a separate /boot partition is no longer required. This change adjusts multiple steps in the conversion process to handle boot files directly from the root filesystem or skip boot partition setup entirely. Key changes: - Skip extracting /boot to a separate partition when UKI mode is enabled - Do not create a physical boot partition on disk - Adjust LVM partition start sector: reuse original root partition number and layout when no boot partition is created - Conditionally update /etc/fstab only if not in UKI mode - Update chroot mount logic to skip mounting /boot if using UKI - Pass 'uki' flag through step:update_rootfs and other functions - Handle empty boot_part in step:update_initrd for UKI mode This simplifies disk layout in UKI scenarios and aligns with modern single-image boot practices. Signed-off-by: Kun Lai <laikun@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --uki is specified, a separate /boot partition is no longer required. This change adjusts multiple steps in the conversion process to handle boot files directly from the root filesystem or skip boot partition setup entirely.
Key changes:
This simplifies disk layout in UKI scenarios and aligns with modern single-image boot practices.