-
Notifications
You must be signed in to change notification settings - Fork 1
adding simulatable neuron class and registering function #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks @AurelienJaquier! Do you also want to link the SimulatableNeuron class to the EModelWorkflow in this PR or do you plan to do it in another one? |
Done in latest commit |
| fitness_configuration_id (str): FitnessCalculatorConfiguration id | ||
| emodels (list): list of EModel ids | ||
| emodel_scripts_id (list): list of EModelScript ids | ||
| simulatable_neuron_ids (list): list of SimulatableNeuron ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a list because you want to add all the related resource IDs of SimulatableNeuron to one list without any order or names. Do you not want to distinguish between different IDs of different resource types: morphology, mechanisms, etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a list because a workflow can produce multiple emodels (using multiple seeds)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mechanisms id, morphology id are listed in simulatable neuron class. They are also present in emodel configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a list because a workflow can produce multiple emodels (using multiple seeds)
Oh, alright. So, to access the best one e.g. similar to one generate hoc function, do you plan to create a function for SimulatebleNeuron?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. We don't do that in generate hoc function
Since we are going to move away from nexus, I took some liberties:
This has not been tested yet. We are waiting on being able to use nexus again.