Skip to content

Conversation

@mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented Jan 13, 2026

  • Create "standard" BrainAtlasRegion endpoints
  • Add create/update/delete for /brain-atlas/

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
pytest 97.63% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/filters/brain_atlas.py 100.00% <100.00%> (ø)
app/routers/__init__.py 100.00% <ø> (ø)
app/routers/brain_atlas.py 100.00% <100.00%> (ø)
app/routers/brain_atlas_region.py 100.00% <100.00%> (ø)
app/schemas/brain_atlas.py 100.00% <100.00%> (ø)
app/schemas/brain_atlas_region.py 100.00% <100.00%> (ø)
app/service/brain_atlas.py 100.00% <100.00%> (+4.34%) ⬆️
app/service/brain_atlas_region.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgeplf
Copy link
Collaborator Author

mgeplf commented Jan 14, 2026

I reran make extract-traces and this didn't seem to make any changes; since I've added new endpoints and tests, shouldn't it @GianlucaFicarelli?

pass


class BrainAtlasRegionBase(BaseModel):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split the BrainAtlasRegion into a separate schema file

Copy link
Contributor

@eleftherioszisis eleftherioszisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mgeplf
Copy link
Collaborator Author

mgeplf commented Jan 14, 2026

I reran make extract-traces

Nevermind; I see it's used in entitysdk, and that's where the traces are.

@mgeplf mgeplf merged commit 8dadd1d into main Jan 14, 2026
2 checks passed
@mgeplf mgeplf deleted the add-brain-atlas-regions branch January 14, 2026 08:49
GianlucaFicarelli added a commit that referenced this pull request Jan 16, 2026
* origin/main:
  Update `brain-atlas` endpoints (#506)
  Add published_in filter in ScientificArtifact (#505)
  Make nullable attributes of EMDenseReconstructionDataset (#503)
  Remove all endpoints that had a `InBrainRegionDep`, but don't have a brain_region_id (#501)
  Add pref_label/alt_label ilike_search to ETypeClass/MTypeClass filters (#500)
  add `number_neurons` to Simulation` (#493)
  Fix incorrect returned values when getting `ascendants_and_descendants` (#498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants