Css color consistency #1431
Open
Css color consistency #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make more dropdowns have the same background and text color for hovered options.
Make the published cell in the events table look like other cells with similar appearance.
In the table heeader, fix both sorting chevrons being colored as "active", instead of only one. Also make the active chevron darker to be more easily recognizable.
Arnei
added
type:code-enhancement
Contributor
|
This pull request has conflicts ☹ |
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
css-color-consistency
branch
from
166c3cc to
ea1a238
Compare
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1431/2025-12-01_13-20-35/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1400. #1400 Should be reviewed and merged first.
This PR replaces the "hardcoded" color values that are flying around everywhere in our scss files with the color variables defined in
_variables.scss. Color values that are not represented by our variables are either added to the variables file, or replaced with a variable with a similar value.Goals:
How to test this
This touches every element that has color, so unfortunately pretty much everything. Quickly click through everything ui element you can find and check if any colors appear "off".